[WIP] Rebar refactoring #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebe
reviewed
Apr 12, 2019
|
|
||
| # Include target-specific sources and input generation recipes | ||
| include $(TARGET_PROJECT_MAKEFRAG) | ||
|
|
||
| verilog: $(VERILOG) | ||
| compile: $(VERILOG) | ||
|
|
||
| # Phony targets for launching the sbt shell and running scalatests | ||
| sbt: $(FIRRTL_JAR) |
There was a problem hiding this comment.
Do you ever mark these as phony with .PHONY?
There was a problem hiding this comment.
Not this Makefile, will fix.
| @@ -21,62 +21,36 @@ def isolateAllTests(tests: Seq[TestDefinition]) = tests map { test => | |||
|
|
|||
| testGrouping in Test := isolateAllTests( (definedTests in Test).value ) | |||
|
|
|||
| val rocketChipDir = file("target-rtl/firechip/rocket-chip") | |||
| val fireChipDir = file("target-rtl/firechip") | |||
| lazy val firesimAsLibrary = sys.env.get("FIRESIM_STANDALONE") == None | |||
There was a problem hiding this comment.
I think this is fine. I've used sys.props and -D options when invoking sbt b/c I thought that was a little more explicit, but environment vars are fine too.
There was a problem hiding this comment.
Ah, sounds good.
|
|
||
| $(info Firesim standalone) | ||
|
|
||
| base_dir := $(firesim_base_dir) | ||
|
|
||
| SBT ?= sbt |
There was a problem hiding this comment.
Is it intentional that SBT and related vars are not defined in the else?
There was a problem hiding this comment.
Yeah, they are defined in rebar's makefrag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an initial pass at the rebar refactoring. It moves the FireSim-class targets into firechip entirely, much as it would be in a general chip project.
TODO:
You now need to
export FIRESIM_STANDALONEto indicate firesim is being used as top. This is kinda hacky, i'm open to better ways of dealing with this, but i figure since you need to sourceme to do anything else interesting, it's not marginally more hacky.