Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two Block Device Widget Fixes #325

Merged
merged 9 commits into from
Jul 24, 2019
Merged

Two Block Device Widget Fixes #325

merged 9 commits into from
Jul 24, 2019

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented Jul 24, 2019 •
edited
Loading

This PR fixes two bugs in the block device widget on dev. See ucb-bar/midas#137

  1. Pulls @armiasalib fix from master into dev (see Stall for bdev_rresp_stalled #305)
  2. Fixes a determinism bug whereby block device read requests would be served early under different host stalling behavior. Ideally the timing model in the block-device widget would be FAME1 transformed -- this would trivially gate state updates to the timing model under stall. I figured it was easier to instead change the DynamicLatencyPipe in MIDAS to simply drive valid high combinationally on cycle match.

@davidbiancolin davidbiancolin mentioned this pull request Jul 24, 2019
Merged
zhemao
zhemao approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@zhemao zhemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the requested changes in MIDAS

@davidbiancolin davidbiancolin merged commit c56112e into dev Jul 24, 2019
@davidbiancolin davidbiancolin deleted the blkdev-fixes branch July 24, 2019 21:49
@davidbiancolin davidbiancolin mentioned this pull request Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhemao zhemao zhemao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidbiancolin @zhemao @armiasalib