Skip to content

Commit

Permalink
fix(icmp): fix check_icmpv6_name() to use correct IPv6 names
Browse files Browse the repository at this point in the history
This was only called from IPSet.check_entry() to validate the input.
Also, some of the IPv4 names are the same as for IPv6. Overall, the
impact of this was probably low.

Fixes: 11567b7 ('New firewall.core.icmp providing names and types for icmp and icmpv6 values')
(cherry picked from commit d2fa474)
  • Loading branch information
thom311 authored and erig0 committed Oct 2, 2023
1 parent ebf398c commit 762fbf4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/firewall/core/icmp.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def check_icmp_type(_type):
return False

def check_icmpv6_name(_name):
if _name in ICMP_TYPES:
if _name in ICMPV6_TYPES:
return True
return False

Expand Down

0 comments on commit 762fbf4

Please sign in to comment.