Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker swarm service #230

Merged
merged 4 commits into from
Oct 13, 2017
Merged

Conversation

tdobrovolny
Copy link
Contributor

Docker swarm service allow communication between docker engines in
swarm mode.

Docker swarm service allow communication between docker engines in
swarm mode.
Correct misspelled element name and renamed attribute
@erig0
Copy link
Collaborator

erig0 commented Sep 13, 2017

You also need to update config/Makefile.am

Copy link
Collaborator

@erig0 erig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the link below this should also include TCP port 2376. Is that accurate?

https://www.digitalocean.com/community/tutorials/how-to-configure-the-linux-firewall-for-docker-swarm-on-centos-7

<?xml version="1.0" encoding="utf-8"?>
<service>
<short>Docker swarm</short>
<description>Ports and protocol required by docker in swarm mode</description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a one line description of Docker Swarm not a description of the service file.

Improve short and description of the service.
@tdobrovolny
Copy link
Contributor Author

TCP port 2376 is not required by docker engines running in swarm mode. See https://docs.docker.com/engine/swarm/swarm-tutorial/#open-protocols-and-ports-between-the-hosts

Your link describes legacy standalone swarm used on docker prior the version 1.12. See https://docs.docker.com/swarm/provision-with-machine/

So if you want also open port 2376 needed for docker-machine and legacy swarm, I recommend have two firewalld services. One for "Docker legacy Swarm" also with port 2376 and one for "Docker integrated Swarm" without 2376 port.

@erig0 erig0 merged commit 9d899ff into firewalld:master Oct 13, 2017
@FruityWelsh
Copy link

This TCP port is also used by Rancher nodes as per the Rancher req docs. For "Docker daemon TLS port used by Docker Machine (only needed when using Node Driver/Templates)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants