-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker swarm service #230
Conversation
Docker swarm service allow communication between docker engines in swarm mode.
Correct misspelled element name and renamed attribute
You also need to update config/Makefile.am |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the link below this should also include TCP port 2376. Is that accurate?
config/services/docker-swarm.xml
Outdated
<?xml version="1.0" encoding="utf-8"?> | ||
<service> | ||
<short>Docker swarm</short> | ||
<description>Ports and protocol required by docker in swarm mode</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a one line description of Docker Swarm not a description of the service file.
Improve short and description of the service.
TCP port 2376 is not required by docker engines running in swarm mode. See https://docs.docker.com/engine/swarm/swarm-tutorial/#open-protocols-and-ports-between-the-hosts Your link describes legacy standalone swarm used on docker prior the version 1.12. See https://docs.docker.com/swarm/provision-with-machine/ So if you want also open port 2376 needed for docker-machine and legacy swarm, I recommend have two firewalld services. One for "Docker legacy Swarm" also with port 2376 and one for "Docker integrated Swarm" without 2376 port. |
This TCP port is also used by Rancher nodes as per the Rancher req docs. For "Docker daemon TLS port used by Docker Machine (only needed when using Node Driver/Templates)". |
Docker swarm service allow communication between docker engines in
swarm mode.