Adding Reset Command #35
Conversation
Codecov Report
@@ Coverage Diff @@
## php #35 +/- ##
============================================
+ Coverage 78.13% 82.33% +4.19%
- Complexity 92 116 +24
============================================
Files 35 37 +2
Lines 279 351 +72
============================================
+ Hits 218 289 +71
- Misses 61 62 +1
Continue to review full report at Codecov.
|
app/Commands/Reset.php
Outdated
| $environment->overloadEnv($environment->getContextEnv($envFile)); | ||
| } | ||
|
|
||
| return collect([ |
There was a problem hiding this comment.
Add a comment explaining this
app/Commands/Reset.php
Outdated
| return $process->dockerRun(env('FWD_IMAGE_NODE'), 'yarn install'); | ||
| }, | ||
| function () use ($process) { | ||
| return $process->dockerRun(env('FWD_IMAGE_NODE'), 'yarn dev'); |
app/Commands/Reset.php
Outdated
| ); | ||
| }, | ||
| function () use ($process) { | ||
| return $process->dockerRun(env('FWD_IMAGE_NODE'), 'yarn install'); |
app/Commands/Reset.php
Outdated
|
|
||
| return collect([ | ||
| function () use ($process) { | ||
| return $process->dockerComposeExec('app composer install'); |
app/Commands/Reset.php
Outdated
| function () use ($process) { | ||
| return $process->dockerRun(env('FWD_IMAGE_NODE'), 'yarn dev'); | ||
| }, | ||
| ])->first(function ($command) { |
There was a problem hiding this comment.
first will return the closure in case of exit code different than 0, instead of the actual return code. We need to think in a different way maybe... a simple foreach
|
Other thing: instead of having all those closures, let's use callables like |
I like that, maybe a |
|
@gabrielboliveira @fabriciojs updated |
No description provided.