Skip to content
This repository has been archived by the owner on Feb 15, 2021. It is now read-only.

Add new Docker command #36

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

gabrielboliveira
Copy link
Contributor

New fwd docker command

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #36 into php will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                php      #36      +/-   ##
============================================
+ Coverage     78.13%   78.67%   +0.53%     
- Complexity       92       95       +3     
============================================
  Files            35       36       +1     
  Lines           279      286       +7     
============================================
+ Hits            218      225       +7     
  Misses           61       61
Impacted Files Coverage Δ Complexity Δ
app/Process.php 47.16% <100%> (+3.16%) 16 <1> (+1) ⬆️
app/Commands/Docker.php 100% <100%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbc70f...64b8ade. Read the comment docs.

@dbpolito
Copy link
Member

dbpolito commented Apr 17, 2019

Why? How/when would you use it? I can't see a use case at the moment. Not against, just curious how you will use it.

@dbpolito
Copy link
Member

dbpolito commented Apr 17, 2019

My point is, what the benefit of running fwd docker instead of just docker, not mounting volumes or anything... does it uses env var properly on the docker container afterwards?

@gabrielboliveira
Copy link
Contributor Author

does it uses env var properly on the docker container afterwards?

This is the main point of this. If you need to override any env variables on your .env, using fwd docker will use those variables instead of just docker.

Example: if you use fireworkweb/fwd:latest as image but use docker instead of fwd docker, if you override DOCKER_HOST, it wouldn't work.

@dbpolito dbpolito merged commit abcf65b into fireworkweb:php Apr 17, 2019
@gabrielboliveira gabrielboliveira deleted the add-docker-command branch April 17, 2019 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants