Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix User-Agent fallback. #106

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Fix User-Agent fallback. #106

merged 1 commit into from
Jan 12, 2021

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jan 9, 2021

In the current code the variable userAgent is assigned but unused. The indented behavior seems to use defaultUserAgent if worker.UserAgent is empty. Found by ineffassign.

@itchyny itchyny self-assigned this Jan 9, 2021
tarao
tarao approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@tarao tarao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itchyny LGTM

@itchyny
Copy link
Contributor Author

itchyny commented Jan 12, 2021

Thank you.

@itchyny itchyny merged commit 9e51fc6 into master Jan 12, 2021
@itchyny itchyny deleted the fix-user-agent-fallback branch January 12, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarao tarao tarao approved these changes

Assignees

@itchyny itchyny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itchyny @tarao