bump mysql version upto 8.0 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VALUES with ON DUPLICATE is deprecated since MySQL 8.0.20. Row aliasing (AS after VALUES) can avoid this deprecation. cf. https://dev.mysql.com/doc/refman/8.0/en/insert-on-duplicate.html
…LICATE" This reverts commit 0f0fed8.
Benchmark TestI tested Fireworq score between MySQL 5.7 vs MySQL 8.0 (AWS RDS) using fireworq/benchworker. Score got worse, but we can recover it using newer RDS instance. MySQL 8.0 on
Comparing MySQL 5.7 on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to approaching of MySQL 5.7 EOL, we have to bump supported mysql version.
First, I updated version of MySQL of Dockerfile upto 8.0 for test.
Did
Fixed deprecated syntax (VALUESinsideON DUPLICATEclause)This causes breaking changeBreaking ChangeNew syntax (row aliasing) introduced -- this is only availavle since MySQL 8.0It results dropping support of MySQL 5.7Breaking Change retracted
To support smooth migration, we have to provide release supports both MySQL version. We can hold breaking change in further release. This PR sustains support for MySQL 5.7.
cf. #183
cf. https://dev.mysql.com/doc/refman/8.0/en/insert-on-duplicate.html