Add TotalPermanentFailures #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Help wanted] Build in Travis CI fails at golint with the following error. As I can see, there are no other failures. I assume this is a bug of test script, but it is difficult for me to inspect the problem due to lack of knowledge. Can you find a cause of the problem? |
github.com/golong/lint/golint is a mirror. golang.org/x/lint/golint is found in the official README.
yigarashi-9
force-pushed
the
add-total-permanent-failures-stat
branch
from
d9bd219
to
c97c396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I added
TotalPermanetFailuresto job queue statistics. Its value is incremented when a job finishes withpermanet-failurestatus.Why
TotalFailuresincludes non-critical failures followed by retries.TotalPermanentFailurescounts only (probably) critical failures, which is useful for monitoring.