Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-run] No need to checkout the branch on CI #34

Merged
merged 1 commit into from
Jul 18, 2019
Merged

[docker-run] No need to checkout the branch on CI #34

merged 1 commit into from
Jul 18, 2019

Conversation

ikesyo
Copy link
Contributor

@ikesyo ikesyo commented Jul 17, 2019

Possibly resolves #33.

@ikesyo ikesyo changed the title [docker-run] Use TRAVIS_PULL_REQUEST_BRANCH [WIP][docker-run] Use TRAVIS_PULL_REQUEST_BRANCH Jul 17, 2019
@ikesyo
Copy link
Contributor Author

ikesyo commented Jul 17, 2019 •
edited
Loading

Okay just using TRAVIS_PULL_REQUEST_BRANCH doesn’t work.

@ikesyo ikesyo force-pushed the patch-1 branch 3 times, most recently from dc2c68c to 799f08a Compare July 17, 2019 17:07
@ikesyo ikesyo changed the title [WIP][docker-run] Use TRAVIS_PULL_REQUEST_BRANCH [docker-run] Use TRAVIS_PULL_REQUEST_BRANCH Jul 17, 2019
@ikesyo ikesyo changed the title [docker-run] Use TRAVIS_PULL_REQUEST_BRANCH [WIP][docker-run] Use TRAVIS_PULL_REQUEST_BRANCH Jul 17, 2019
@ikesyo ikesyo changed the title [WIP][docker-run] Use TRAVIS_PULL_REQUEST_BRANCH [docker-run] No need to checkout the branch on CI Jul 18, 2019
@tarao
Copy link
Member

tarao commented Jul 18, 2019

I don't remember why we needed this (maybe just in case for other CI such as Jenkins?).
Anyway, I agree that there must be no need to checkout the branch. Let's just see if it works.

@tarao tarao merged commit 76ebf1d into fireworq:master Jul 18, 2019
@ikesyo ikesyo deleted the patch-1 branch July 18, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

script/ci/test/docker-run does not support testing pull requests from forked repositories
2 participants
@ikesyo @tarao