Add order parameter to jobs inspecting API #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sixeight
commented
Aug 23, 2019
jobqueue/mysql/inspector.go
Outdated
| } | ||
| } | ||
|
|
||
| func (i *inspector) findAllAsc(status string, minTime int64, maxTime int64, limit uint, cursor string) (*jobqueue.InspectedJobs, error) { |
There was a problem hiding this comment.
This method has many duplicated code with findAllDesc 🤔 but I cannot split these method as simple.
There was a problem hiding this comment.
It doesn't surprise me. There is duplicated code already in failureLog.
tarao
requested changes
Aug 23, 2019
jobqueue/mysql/inspector.go
Outdated
| maxTime = int64(t) | ||
| maxJobID = uint64(j) | ||
| *time = int64(t) | ||
| *jobID = uint64(j) |
There was a problem hiding this comment.
This mutation looks tricky to me. Consider making this function immutable by taking default values and returning a pair:
func decodeCursor(cursor string, defaultTime int64, defaultJobID uint64) (time int64, jobID uint64)
jobqueue/mysql/inspector.go
Outdated
| } | ||
| } | ||
|
|
||
| func (i *inspector) findAllAsc(status string, minTime int64, maxTime int64, limit uint, cursor string) (*jobqueue.InspectedJobs, error) { |
There was a problem hiding this comment.
It doesn't surprise me. There is duplicated code already in failureLog.
| if len(r2.Jobs) != 0 { | ||
| t.Error("There must be no waiting job in the queue") | ||
| } | ||
|
|
||
| r3, err := i.FindAllDeferred(uint(100), "") | ||
| r3, err := i.FindAllDeferred(uint(100), "", jobqueue.Desc) |
There was a problem hiding this comment.
It would be better to have tests for asceding order too.
|
@tarao Thank you for your review. I've corresponded to your point. Could you review again? |
Sixeight
force-pushed
the
add-sort-order-to-joblist-api
branch
from
ecb85d9
to
3e86a12
Compare
tarao
approved these changes
Aug 23, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
orderparameter for jobs inspecting API. We can inspect jobs in arbitrary order byfnext_tryfield.Why
/queue/default/waiting?order=asc&limit=1satisfies the behavior.