Do not block pushing jobs during config reload #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the process to stop dispatchers from `destroyQueues` as `deactivateQueues` and introduce a new mutex for pushing jobs which won't be locked by the deactivation.
itchyny
approved these changes
Nov 21, 2019
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When queues are reloaded (by changing a queue config), a new job is accepted by the HTTP server but blocked by
Serviceuntil the whole reloading process completes. Especially, stopping dispatchers will take long because they wait for workers to respond.How to solve
Accept new jobs during stopping dispatchers. It is safe to push a new job even if no dispatcher is running.
Change summary
destroyQueuesasdeactivateQueues.