Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce scopelint #58

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Introduce scopelint #58

merged 2 commits into from
Mar 9, 2020

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Mar 9, 2020

This pull request introduces scopelint, which prevents from a kind of common mistakes in Go. Also fixed one warning as suggested by the lint.

@itchyny itchyny self-assigned this Mar 9, 2020
tarao
tarao approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@tarao tarao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itchyny LGTM

@itchyny
Copy link
Contributor Author

itchyny commented Mar 9, 2020

Thank you.

@itchyny itchyny merged commit c2a0859 into master Mar 9, 2020
@itchyny itchyny deleted the introduce-scopelint branch March 9, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarao tarao tarao approved these changes

Assignees

@itchyny itchyny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itchyny @tarao