Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaving log files from tests #66

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Fix leaving log files from tests #66

merged 2 commits into from
Jun 9, 2020

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jun 8, 2020

Currently go test . leaves test-access.log and test-error.log, which are not ignored by .gitignore. This pr fixes this problem.

tarao
tarao approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@tarao tarao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itchyny LGTM

@itchyny
Copy link
Contributor Author

itchyny commented Jun 9, 2020

Thank you.

@itchyny itchyny merged commit 2892788 into master Jun 9, 2020
@itchyny itchyny deleted the add-log-gitignore branch June 9, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarao tarao tarao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itchyny @tarao