Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use org secrets instead of the repository one #84

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Use org secrets instead of the repository one #84

merged 1 commit into from
Sep 1, 2020

Conversation

Sixeight
Copy link
Contributor

What

  • Use org secrets to publish docker image to Docker Hub on Action.
  • I'll remove repository secrets.

@Sixeight Sixeight self-assigned this Aug 31, 2020
yigarashi-9
yigarashi-9 approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@yigarashi-9 yigarashi-9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sixeight
Copy link
Contributor Author

Sixeight commented Sep 1, 2020

Thank you!

@Sixeight Sixeight merged commit 94ef644 into master Sep 1, 2020
@Sixeight Sixeight deleted the use-org-secrets-for-dockerhub branch September 1, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yigarashi-9 yigarashi-9 yigarashi-9 approved these changes

Assignees

@Sixeight Sixeight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sixeight @yigarashi-9