Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune log filters for GA #3618

Closed
2 tasks
jamilbk opened this issue Feb 10, 2024 · 0 comments · Fixed by #4319
Closed
2 tasks

Tune log filters for GA #3618

jamilbk opened this issue Feb 10, 2024 · 0 comments · Fixed by #4319
Assignees
@conectado
Labels
area/connlib Firezone's core connectivity library
Milestone
1.0 GA

Comments

@jamilbk
Copy link
Member

jamilbk commented Feb 10, 2024 •
edited
Loading

Ensure logging filters are set appropriately so that we only log info and up, and ensure logged messages contain no sensitive info.

  • Ensure non-Firezone DNS isn't being logged
  • Set all filters to info or higher so that debug logs aren't printed
@jamilbk jamilbk added this to the 1.0 GA milestone Feb 10, 2024
@jamilbk jamilbk added the area/connlib Firezone's core connectivity library label Feb 10, 2024
@jamilbk jamilbk mentioned this issue Feb 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
@jamilbk @thomaseizinger
chore(connlib): Tune log filters to enable debug in dev and info …
2ed6b3d 
…for gateway deployments (#3788)

Refs #3618

---------

Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@jamilbk jamilbk mentioned this issue Mar 4, 2024
Merged
jamilbk added a commit that referenced this issue Mar 4, 2024
@jamilbk
refactor: Reduce log levels for production releases to avoid filling …
8c59ff7 
…customer's… (#3899)

Tuning the logging down a bit on our production releases. Prevents
gathering data we don't need to be gathering and prevents filling up
drive space with debug logs.

refs #3618
@jamilbk jamilbk mentioned this issue Mar 18, 2024
Merged
@jamilbk jamilbk mentioned this issue Mar 26, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@conectado @ReactorScram
chore: set rust log level to info for gateways and client (#4319)
24e0641 
- [x] Updated log level string for client and gateways to info or higher
- [x] Update logs to hide DNS information

I also removed `hickory_resolve` errors which could contain sensitive
info from our general error and hide the logs that specifically relates
to them.

@bmanifold double checking that the log levels in the gateway's `*.tf`
files are just used for our own gateways.

Also, the relays still have `debug`, since only we see that I think that
makes sense but double checking with @jamilbk

Fixes: #3618.

---------

Signed-off-by: Gabi <gabrielalejandro7@gmail.com>
Co-authored-by: Reactor Scram <ReactorScram@users.noreply.github.com>
@jamilbk jamilbk mentioned this issue Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conectado conectado

Labels
area/connlib Firezone's core connectivity library
Projects
None yet
Milestone
1.0 GA
Development

Successfully merging a pull request may close this issue.

chore: set rust log level to info for gateways and client firezone/firezone
2 participants
@jamilbk @conectado