Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During next manual test of CI/CD builds #3887

Closed
2 tasks done
ReactorScram opened this issue Mar 1, 2024 · 2 comments
Closed
2 tasks done

During next manual test of CI/CD builds #3887

ReactorScram opened this issue Mar 1, 2024 · 2 comments
Assignees
@ReactorScram
Labels
area/tauri_client The Windows and Linux Tauri GUI clients complexity/low Something that should not take more than a few hours.
Milestone
1.0 GA

Comments

@ReactorScram
Copy link
Collaborator

ReactorScram commented Mar 1, 2024 •
edited
Loading

I don't do a manual test on CI/CD MSIs / AppImages for every single change, so these can all go into the same cycle next time I do:

Tasks
Beta Give feedback
@ReactorScram ReactorScram added the complexity/low Something that should not take more than a few hours. label Mar 1, 2024
@ReactorScram ReactorScram added this to the 1.0-beta milestone Mar 1, 2024
@ReactorScram ReactorScram self-assigned this Mar 1, 2024
@ReactorScram ReactorScram added the area/tauri_client The Windows and Linux Tauri GUI clients label Mar 1, 2024
@ReactorScram ReactorScram modified the milestones: 1.0-beta, 1.0 GA Mar 7, 2024
@ReactorScram ReactorScram mentioned this issue Mar 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@ReactorScram
build(gui-client/linux): make sure debug symbols get uploaded for the…
651ea3a 
… Linux GUI client (#4217)

- Split up CI artifacts into "exe", "pkg", and "syms" so it's easy to
check they're being uploaded. This shouldn't affect published artifacts
- Set `strip = "none"` which seems to be necessary to get the debug
symbols in Linux, although they still end up in the exe and not the dwp
file 🤔 don't know why
- Test Linux stacktrace in CI

Stacktrace examples:
- On Linux we at least get function names, but we aren't getting line
numbers for some reason
https://github.com/firezone/firezone/actions/runs/8350493514/job/22857032124#step:10:268
- On Windows we also get line numbers, as before
https://github.com/firezone/firezone/actions/runs/8350493514/job/22857033367#step:11:351

I didn't test downloading the files and doing a stacktrace locally, but
I have batched that up for whenever I do a big manual test of the
CD-produced release artifacts:
#3887
@ReactorScram
Copy link
Collaborator Author

Windows 2293aa7 is good

It's much better if #4364 merges

@ReactorScram
Copy link
Collaborator Author

Skipped a bunch of these

The Linux CLI client doesn't have crash handling, I'm not gonna add it before GA cause it's too big a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReactorScram ReactorScram

Labels
area/tauri_client The Windows and Linux Tauri GUI clients complexity/low Something that should not take more than a few hours.
Projects
None yet
Milestone
1.0 GA
Development

No branches or pull requests
1 participant
@ReactorScram