Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Windows Client): Unhelpful error message if the user starts a second instance of Firezone #4363

Closed
ReactorScram opened this issue Mar 28, 2024 · 0 comments · Fixed by #4364
Closed

bug(Windows Client): Unhelpful error message if the user starts a second instance of Firezone #4363

ReactorScram opened this issue Mar 28, 2024 · 0 comments · Fixed by #4364
Assignees
@ReactorScram
Labels
area/windows_client Issues related to the Windows client kind/bug Something isn't working kind/UX Changes related specifically to overall user experience and product quality needs triage Issues opened by the public or need further labeling
Milestone
1.0 GA

Comments

@ReactorScram
Copy link
Collaborator

Describe the bug

It says "Tauri error" in the dialog box

To Reproduce

Run any two instance of Firezone Client

Expected behavior

Expected something actionable like "Firezone is already running" as in previous builds

Screenshots / Logs

image

Platform (please complete the following information)

  • Component (i.e. macOS client / Linux client / Gateway / Admin portal): Windows Client
  • Firezone Version (e.g. 1.0.0 or N/A): 30f6628
  • OS and version: (e.g. Ubuntu 22.04 or N/A): Windows 11
  • Deployment method: (e.g. Docker / Systemd / App Store or N/A): Built from source

Additional context

I suspect this regressed because the error became part of the anyhow variant and silently wasn't caught, when I moved the deep link server inside Tauri's setup function.
@ReactorScram ReactorScram added kind/bug Something isn't working area/windows_client Issues related to the Windows client needs triage Issues opened by the public or need further labeling kind/UX Changes related specifically to overall user experience and product quality labels Mar 28, 2024
@ReactorScram ReactorScram added this to the 1.0 GA milestone Mar 28, 2024
@ReactorScram ReactorScram self-assigned this Mar 28, 2024
ReactorScram added a commit that referenced this issue Mar 28, 2024
@ReactorScram
fix(Windows client): fix "Tauri error" to "Firezone is already runnin…
50e7562 
…g..."

This regressed a while back when I was trying to fix a flaky test.

Closes #4363
@ReactorScram ReactorScram mentioned this issue Mar 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
@ReactorScram
fix(Windows client): fix "Tauri error" to "Firezone is already runnin…
00ddb79 
…g" (#4364)

This regressed a while back when I was trying to fix a flaky test.

Closes #4363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReactorScram ReactorScram

Labels
area/windows_client Issues related to the Windows client kind/bug Something isn't working kind/UX Changes related specifically to overall user experience and product quality needs triage Issues opened by the public or need further labeling
Projects
None yet
Milestone
1.0 GA
Development

Successfully merging a pull request may close this issue.

fix(Windows client): fix "Tauri error" to "Firezone is already running" firezone/firezone
1 participant
@ReactorScram