Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ux(linux-client): panic if DNS control fails #4461

Closed
ReactorScram opened this issue Apr 2, 2024 · 1 comment · Fixed by #4714
Closed

ux(linux-client): panic if DNS control fails #4461

ReactorScram opened this issue Apr 2, 2024 · 1 comment · Fixed by #4714
Assignees
@ReactorScram

Comments

@ReactorScram
Copy link
Collaborator 

          Do we print a loud warning about this?

I'm thinking the most common sad-path here is a user turns Firezone on, thinks their traffic to private.site.com is protected, when in fact they aren't and they're none the wiser.

Originally posted by @jamilbk in #4341 (comment)
@ReactorScram ReactorScram mentioned this issue Apr 2, 2024
Merged
@ReactorScram ReactorScram changed the title ux(linux-client): log a warning if DNS control fails ux(linux-client): panic if DNS control fails Apr 3, 2024
@ReactorScram ReactorScram self-assigned this Apr 3, 2024
ReactorScram added a commit that referenced this issue Apr 22, 2024
@ReactorScram
panic if DNS control fails
f514b51 
Closes <#4461>
@ReactorScram
Copy link
Collaborator Author

#4714 will close this https://github.com/firezone/firezone/pull/4714/files#diff-75c5eebfd3bb7f97a1ee3590ea0eaf5025f5995a47b0fcce27e26ed1a10059d4R283

@ReactorScram ReactorScram linked a pull request Apr 22, 2024 that will close this issue
refactor(linux-client): remove FIREZONE_ID from example systemd file #4714
Merged
@ReactorScram ReactorScram mentioned this issue Apr 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2024
@ReactorScram
refactor(linux-client): remove FIREZONE_ID from example systemd file (#…
bc94078 
…4714)

For tests it doesn't hurt, but this will be used as a template for the
systemd service we ship to production, and that can't have the ID there.

So I'm also cleaning up a few other problems I noticed:
- I wanted to split the service files as part of #4531, so that the GUI
Client and headless Client can have separate sandbox rules. e.g, the
headless Client won't be allowed to create Unix domain sockets
- I'm punting more things to systemd, which allows us to tighten down
the sandbox further, e.g. creating `/var/lib/dev.firezone.client` and
`/run/dev.firezone.client` for us
- Closes #4461

---------

Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReactorScram ReactorScram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(linux-client): remove FIREZONE_ID from example systemd file firezone/firezone
1 participant
@ReactorScram