-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report "connected to Peer" status for each Gateway #4738
Comments
I was planning to set this on the There are still a few questions.
For now I'll go with the easiest to implement, which is only show status after trying connection for specific resources and only switch status when we get a response(important for the offline case!) |
If the data-plane fails either, can't make a connection or the connection times-out should we count that as:
I think a "Failed Connection" status might be good to debug for us but I feel it might make it hard for the user to understand the difference. |
Hmm, I think the main purpose behind this issue was to make it clear to the user (possibly a power user) when it's not possible to connect to any Resources in the Site. I.e. to reflect the "Resource Offline" message from the portal (which isn't entirely accurate -- it's more like a "Site offline" error, right?). If that's the case, we should be tying this status to the Site, and not Resource. I'll have to think more about how to reflect it in the UI, but what do you think of this approach:
Would that work? |
I think for most cases this works until we have multi-site resources |
This PR introduces site's `Status`. That's used to report to the client the status, either, unknown, online or offline, mostly as a hint to users as what's wrong with a connection. This are the criteria for an online or offline resource * If all sites related to a resource are offline the resource is considered offline, since there's no gateway that can respond to that resource's connection * If any site is online the resource is online, since that same peer can be used to reach that resource * Any other case is unknown Right now resources are single site so it doesn't matter too much but tracking online/offline per-site instead of per-gateway or resource seems like the better long-term solution. The way to "find out" the site's status is: * If a response to a connection details is offline, all sites related to that resource must be offline otherwise there would've been a gateway in the response * At the point we connect to a gateway, the site that corresponds to that gateway must be online * When a connection to a peer stops it's considered unknown again Fixes #4738
This PR introduces site's `Status`. That's used to report to the client the status, either, unknown, online or offline, mostly as a hint to users as what's wrong with a connection. This are the criteria for an online or offline resource * If all sites related to a resource are offline the resource is considered offline, since there's no gateway that can respond to that resource's connection * If any site is online the resource is online, since that same peer can be used to reach that resource * Any other case is unknown Right now resources are single site so it doesn't matter too much but tracking online/offline per-site instead of per-gateway or resource seems like the better long-term solution. The way to "find out" the site's status is: * If a response to a connection details is offline, all sites related to that resource must be offline otherwise there would've been a gateway in the response * At the point we connect to a gateway, the site that corresponds to that gateway must be online * When a connection to a peer stops it's considered unknown again Fixes #4738
It would be helpful to know whether a Resource has:
These will be used to show status indicator dots in the Client UI for each resource.
The text was updated successfully, but these errors were encountered: