Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move persistent term cache to cachex #1003

Merged
merged 2 commits into from Oct 5, 2022
Merged

Move persistent term cache to cachex #1003

merged 2 commits into from Oct 5, 2022

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Oct 4, 2022 •
edited

Refactors the DB-based configuration system to use Cachex over persistent_term. This is the first step in the saga of moving ENV vars to runtime configuration.

Cachex was chosen for its in-memory ETS store, which will be slightly slower than persistent_term for reads, but eliminates the risk of accidentally hitting a global GC call.

Baby steps.

@jamilbk jamilbk added the chore label Oct 4, 2022
@jamilbk jamilbk self-assigned this Oct 4, 2022
@coveralls
Copy link

coveralls commented Oct 4, 2022 •
edited

Pull Request Test Coverage Report for Build 2627b097c80003fb0fc4313365ca8534a3e80e69-PR-1003

  • 22 of 26 (84.62%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 67.862%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/fz_http/lib/fz_http/conf/cache.ex 4 5 80.0%
apps/fz_http/lib/fz_http/configurations.ex 6 7 85.71%
apps/fz_http/lib/fz_http/oidc/start_proxy.ex 2 4 50.0%
Totals Coverage Status
Change from base Build 23b38aa91a4aaec41fe32677a8487d8480715c04: 0.2%
Covered Lines: 1098
Relevant Lines: 1618
💛 - Coveralls

@jamilbk jamilbk requested a review from akrousset October 4, 2022 20:49
@jamilbk jamilbk marked this pull request as ready for review October 4, 2022 20:49
@jamilbk jamilbk merged commit 08bf880 into master Oct 5, 2022
@jamilbk jamilbk deleted the fix-tests branch October 5, 2022 10:28
@jamilbk
Copy link
Member Author

jamilbk commented Oct 5, 2022

Merging to fix build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrousset akrousset Awaiting requested review from akrousset

Assignees

@jamilbk jamilbk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamilbk @coveralls