Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use openid_connect master #1573

Merged
merged 3 commits into from
May 1, 2023
Merged

Use openid_connect master #1573

merged 3 commits into from
May 1, 2023

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Apr 22, 2023

Fixes #1571

@jamilbk jamilbk self-assigned this Apr 22, 2023
@jamilbk jamilbk marked this pull request as ready for review April 22, 2023 21:02
@github-actions github-actions bot added the kind/bug Something isn't working label Apr 22, 2023
@coveralls
Copy link

coveralls commented Apr 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 230048cfa3696c0f09dc9fa53b24456a89dd2c4c-PR-1573

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.683%
Totals Coverage Status
Change from base Build 78f8d46da7519bc31c5d02b1b53253081716eb26: 0.0%
Covered Lines: 1965
Relevant Lines: 2780
💛 - Coveralls

AndrewDryga
AndrewDryga previously approved these changes Apr 25, 2023
View reviewed changes
@AndrewDryga
Copy link
Collaborator

AndrewDryga commented Apr 25, 2023 •
edited
Loading

The tests are failing because now we need to set up proper claims for test cases because they are validated in a more recent library version. If you want I can jump into your branch and fix them?

@jamilbk
Copy link
Member Author

jamilbk commented Apr 25, 2023

The tests are failing because now we need to set up proper claims for test cases because they are validated in a more recent library version. If you want I can jump into your branch and fix them?

Sounds good!

@jamilbk jamilbk assigned AndrewDryga and unassigned jamilbk Apr 26, 2023
@jamilbk
Copy link
Member Author

jamilbk commented May 1, 2023

@AndrewDryga Should I just point the ref back to the old commit ID for now?

@AndrewDryga AndrewDryga merged commit b51a972 into master May 1, 2023
1 check passed
@AndrewDryga AndrewDryga deleted the fix/oidc-lib branch May 1, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewDryga AndrewDryga AndrewDryga approved these changes

Assignees

@AndrewDryga AndrewDryga

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build broken? openid_connect andrew/rewrite branch does not exist
3 participants
@jamilbk @coveralls @AndrewDryga