Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPN session expiration query #1586

Merged
merged 3 commits into from
May 4, 2023
Merged

Fix VPN session expiration query #1586

merged 3 commits into from
May 4, 2023

Conversation

AndrewDryga
Copy link
Collaborator

Closes #1578

@AndrewDryga AndrewDryga requested a review from jamilbk May 3, 2023 17:42
@coveralls
Copy link

coveralls commented May 3, 2023 •
edited

Pull Request Test Coverage Report for Build 4440546db5ab8d98e7e40423fc6c776f026f597c-PR-1586

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 70.694%
Totals Coverage Status
Change from base Build 3456fe29ef9da0c3d705681724cd4841952ff1a2: 0.01%
Covered Lines: 1966
Relevant Lines: 2781
💛 - Coveralls

jamilbk
jamilbk previously approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the failing CI

https://github.com/firezone/firezone/actions/runs/4874904059/jobs/8696421174#step:16:24

@jamilbk jamilbk merged commit 669bd5d into master May 4, 2023
1 check passed
@jamilbk jamilbk deleted the andrew/fix-vpn-session-expiration branch May 4, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vpn session expire not work
3 participants
@AndrewDryga @coveralls @jamilbk