Disable on_demand cert provisioning for Caddy
#1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jamilbk
changed the title
jamilbk
changed the title
on_demand cert provisioning for Caddy
Pull Request Test Coverage Report for Build 3f85e5e6361a19b817d35d1c15d675680dc5ded4-PR-1720
💛 - Coveralls |
AndrewDryga
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the Caddy documentation,
on_demandmust be restricted to prevent abuse. In our case, it was not, leading to DoS vector in which a malicious client could DoS thecaddyservice by repeatedly initiating TLS requests with invalid domains at a rate high enough for the ACME service to block the Firezone server.Verified the new caddy configuration works as expected.
Credit to @icekom for responsibly disclosing this issue.