Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port range to_string #1915

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix port range to_string #1915

merged 3 commits into from
Aug 16, 2023

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Aug 16, 2023

Fixes port range to string by explicitly calling the cast function.

Fixes #1867

@jamilbk jamilbk requested a review from conectado August 16, 2023 19:45
@jamilbk jamilbk self-assigned this Aug 16, 2023
@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 7:56pm

@github-actions github-actions bot added the kind/bug Something isn't working label Aug 16, 2023
@jamilbk
Copy link
Member Author

jamilbk commented Aug 16, 2023

Tested locally and works. Hoping to cut 0.7.33 with this fix.

Copy link
Collaborator

@conectado conectado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment but looks good

@jamilbk jamilbk merged commit 5c92e32 into legacy Aug 16, 2023
4 checks passed
@jamilbk jamilbk deleted the fix/port-range branch August 16, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants