Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connlib): remove unnecessary Serialize derive #3595

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

thomaseizinger
Copy link
Member

These messages are only deserialized, never serialized. The derive can thus be removed.

Extracted from: #3391.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Feb 7, 2024 7:50am

Copy link

github-actions bot commented Feb 7, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 7 to change, 9 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Feb 7, 2024

Performance Test Results: direct-perf

TCP

Direction Received/s Sent/s Retransmits
Client to Server 131.2 MiB (-0%) 131.2 MiB (-0%) 131 (-35%)
Server to Client 92.7 MiB (+1%) 93.5 MiB (+1%) 110 (+9%)

UDP

Direction Total/s Jitter Lost
Client to Server 250.0 MiB (-0%) 0.03ms (-55%) 64.37% (-1%)
Server to Client 250.0 MiB (-0%) 0.16ms (-16%) 42.12% (+5%)

Copy link

github-actions bot commented Feb 7, 2024

Performance Test Results: relayed-perf

TCP

Direction Received/s Sent/s Retransmits
Client to Server 43.2 MiB (+7%) 43.3 MiB (+7%) 24 (-47%)
Server to Client 55.7 MiB (-5%) 56.5 MiB (-4%) 340 (-43%)

UDP

Direction Total/s Jitter Lost
Client to Server 250.0 MiB (-0%) 0.22ms (+9%) 73.61% (+1%)
Server to Client 249.9 MiB (+0%) 0.20ms (-60%) 94.88% (-1%)

@conectado conectado added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit d550c9d Feb 7, 2024
49 checks passed
@conectado conectado deleted the refactor/connlib/remove-serialize branch February 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants