Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ipad): Allow NavigationView to occupy entire screen #3908

Merged
merged 5 commits into from
Mar 4, 2024
Merged

fix(ipad): Allow NavigationView to occupy entire screen #3908

merged 5 commits into from
Mar 4, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Mar 4, 2024

Before

IMG_0059

After

IMG_0067
IMG_0066
IMG_0065

@jamilbk jamilbk requested a review from roop March 4, 2024 15:41
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 10:36pm

@jamilbk jamilbk changed the base branch from main to refactor/add-logo-padding-apple March 4, 2024 15:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Terraform Cloud Plan Output

Plan: 8 to add, 7 to change, 8 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 65.1 MiB (-2%) 65.6 MiB (-2%) 58 (+49%)
direct-tcp-server2client 54.2 MiB (-0%) 54.5 MiB (-0%) 44 (+26%)
relayed-tcp-client2server 29.7 MiB (-3%) 32.1 MiB (-1%) 31 (-67%)
relayed-tcp-server2client 29.9 MiB (+0%) 32.5 MiB (+0%) 309 (+110%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.24ms (+36%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.16ms (+2%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.36ms (+41%) 35.58% (+93%)
relayed-udp-server2client 50.0 MiB (+0%) 0.40ms (+77%) 18.94% (-4%)

@jamilbk jamilbk requested a review from bmanifold March 4, 2024 15:54
bmanifold
bmanifold approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from refactor/add-logo-padding-apple to main March 4, 2024 22:24
@jamilbk jamilbk enabled auto-merge March 4, 2024 22:34
@jamilbk jamilbk added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 6706db4 Mar 4, 2024
66 checks passed
@jamilbk jamilbk deleted the fix/ipad-ui branch March 4, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmanifold bmanifold bmanifold approved these changes

@roop roop Awaiting requested review from roop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamilbk @bmanifold