feat(connlib): reduce stack size usage #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
thomaseizinger
force-pushed
the
refactor/phoenix-channel-clients
branch
from
636fd5f
to
29773a2
Compare
thomaseizinger
force-pushed
the
feat/reduce-stack-size
branch
from
8888c97
to
499f5d8
Compare
thomaseizinger
force-pushed
the
refactor/phoenix-channel-clients
branch
from
812dda4
to
3667d92
Compare
thomaseizinger
force-pushed
the
feat/reduce-stack-size
branch
2 times, most recently
from
24df509
to
a39a2d9
Compare
|
@conectado Ready for review now! |
Performance Test ResultsTCP
UDP
|
conectado
approved these changes
Mar 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the use of
snownet, we now have explicit control over how we read and write messages to sockets. As such, we can make the remaining stack-allocated buffer heap-allocated and remove the increased stack-size on our tokio worker threads.