Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snownet): always force a handshake when we change the socket #3985

Merged

Conversation

thomaseizinger
Copy link
Member

Some local testing identified that we might lose the first packet if we switch the sockets too quickly, i.e. upgrade from a relayed one to a direct one initially. To mitigate having to wait for the wireguard timeout here, let's force a handshake every time we switch to a new socket.

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Mar 6, 2024 1:39am

Copy link

github-actions bot commented Mar 6, 2024

Terraform Cloud Plan Output

Plan: 8 to add, 7 to change, 8 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Mar 6, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 66.3 MiB (-0%) 66.8 MiB (-0%) 57 (+16%)
direct-tcp-server2client 54.0 MiB (+2%) 54.2 MiB (+1%) 41 (+28%)
relayed-tcp-client2server 29.4 MiB (+3%) 30.3 MiB (-4%) 116 (+49%)
relayed-tcp-server2client 29.2 MiB (-0%) 31.3 MiB (-1%) 341 (+228%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.17ms (+13%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.15ms (-41%) 0.00% (-100%)
relayed-udp-client2server 50.0 MiB (-0%) 0.29ms (+3%) 18.53% (-0%)
relayed-udp-server2client 50.0 MiB (-0%) 0.56ms (-46%) 19.15% (-43%)

@thomaseizinger thomaseizinger added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 2f74edd Mar 6, 2024
66 checks passed
@thomaseizinger thomaseizinger deleted the feat/snownet/always-force-handshake-on-socket-change branch March 6, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants