feat(snownet): log duration since intent after WG handshake completes #3991
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
thomaseizinger
force-pushed
the
feat/snownet/connection-establish-time
branch
from
61b5701
to
8c17cc2
Compare
thomaseizinger
force-pushed
the
feat/snownet/connection-establish-time
branch
2 times, most recently
from
5351880
to
e509715
Compare
|
@conectado I ended up buiilding #4047 on top of this which undoes a few of the changes in here. However, it was easier to just layer it on top rather than starting again and having lots of conflicts. This PR should be non-controversial so if you have any feedback on the internal design, I'd suggest to leave it on #4047. Thanks! :) |
| stun_servers: HashSet<SocketAddr>, | ||
| turn_servers: HashSet<SocketAddr>, | ||
|
|
||
| stats: ConnectionStats, | ||
|
|
||
| buffer: Box<[u8; MAX_UDP_SIZE]>, |
There was a problem hiding this comment.
the buffer name feels a bit generic here
There was a problem hiding this comment.
That is changing in the follow-up PR I linked above!
It would be nice to assert automatically but we'd need some form of structured reporting of these metrics like OTEL or prometheus. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
thomaseizinger
force-pushed
the
feat/snownet/connection-establish-time
branch
from
e509715
to
eb85bf8
Compare
thomaseizinger
force-pushed
the
feat/snownet/connection-establish-time
branch
from
eb85bf8
to
d581aea
Compare
Preceded by some refactoring, this PR adds a log line with a very important metric: Time since connection intent after WG handshake. This is the equivalent of time-to-first-byte, i.e. how long the user needs to wait to actually send their first application data after they've tried for the firs time (and generated an intent).