fix(apple): Align fields in Advanced Settings #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
iOS: 
|
roop
changed the title
roop
force-pushed
the
roop/align_advanced_settings_form
branch
from
d8a2219
to
809e0ef
Compare
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
|
It looks a little better, but it might be better to move the labels above the input boxes instead in the same VStack? That would give more space for the actual input. Then everything can just be left-aligned and only the log filter will run off. |
Instead of having the field name to the left and the editable value to the right, we now have the field name on top (in small size) and the editable value below that.
roop
force-pushed
the
roop/align_advanced_settings_form
branch
from
809e0ef
to
5e76e91
Compare
roop
changed the title
|
@jamilbk: Ok, I've redone the UI per your idea (it doesn't use the same VStack, rather uses nested VStacks): 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the fields in the iOS Advanced Settings form.
Fixes #3997.