Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): In resources list, tapping on a list item shows a 'Copy Address' menu #4050

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

roop
Copy link
Contributor

@roop roop commented Mar 8, 2024

Previousy, tapping on a resource list item in iOS copied the resource address.

In this PR, tapping on a resource list item in iOS shows a menu with "Copy Address", tapping on which copies the resource address.

Fixes #3998.

@roop roop requested a review from jamilbk March 8, 2024 08:00
Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Mar 8, 2024 8:00am

Copy link

github-actions bot commented Mar 8, 2024

Terraform Cloud Plan Output

Plan: 8 to add, 7 to change, 8 to destroy.

Terraform Cloud Plan

@roop
Copy link
Contributor Author

roop commented Mar 8, 2024

Typically, we'd use a .contextMenu for this, but that gets triggered only with a long press. Since we want the menu to show up on a simple tap (which is probably better for UI discoverability), we use a Menu.

How it looks (iOS):

RPReplay_Final1709884464.mov

Copy link

github-actions bot commented Mar 8, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 65.8 MiB (+0%) 66.2 MiB (-0%) 36 (-8%)
direct-tcp-server2client 54.7 MiB (+4%) 55.0 MiB (+4%) 36 (-33%)
relayed-tcp-client2server 27.6 MiB (-5%) 31.1 MiB (-1%) 82 (-67%)
relayed-tcp-server2client 28.7 MiB (+1%) 30.8 MiB (+2%) 191 (+2%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.16ms (+7%) 0.00% (-100%)
direct-udp-server2client 50.0 MiB (0%) 0.22ms (+15%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.22ms (+31%) 29.45% (+39%)
relayed-udp-server2client 50.0 MiB (-0%) 0.29ms (+9%) 21.66% (-2%)

Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jamilbk jamilbk added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 822a30c Mar 8, 2024
64 checks passed
@jamilbk jamilbk deleted the roop/copy_resource_address_through_menu branch March 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove copy icon in list on iOS and replace with a touch event that pops over a Copy Address option
2 participants