Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relay): improve logs for expiry and deletion of channel bindings #4089

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

thomaseizinger
Copy link
Member

@thomaseizinger thomaseizinger commented Mar 12, 2024

Unfortunately, the current logs don't allow us to correlate, which allocation and thus which client the expired channel binding relates to. This PR fixes this by adding more fields to the relevant log messages.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:07am

Copy link

github-actions bot commented Mar 12, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 7 to change, 9 to destroy.

Terraform Cloud Plan

@thomaseizinger thomaseizinger added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 61.5 MiB (-1%) 62.0 MiB (-2%) 59 (+23%)
direct-tcp-server2client 54.0 MiB (-1%) 54.4 MiB (-0%) 40 (+18%)
relayed-tcp-client2server 28.1 MiB (-3%) 30.0 MiB (-3%) 390 (+730%)
relayed-tcp-server2client 28.4 MiB (+3%) 31.5 MiB (+7%) 601 (-17%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.23ms (+17%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.21ms (+24%) 0.34% (+Infinity%)
relayed-udp-client2server 50.0 MiB (+0%) 0.17ms (-41%) 22.16% (-0%)
relayed-udp-server2client 50.0 MiB (-0%) 0.24ms (-25%) 19.96% (-25%)

@thomaseizinger thomaseizinger added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 32e16ec Mar 12, 2024
137 checks passed
@thomaseizinger thomaseizinger deleted the fix/relay/expire-channel-bindings branch March 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants