Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relay): actually expire channels which allows re-binding them #4094

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

thomaseizinger
Copy link
Member

@thomaseizinger thomaseizinger commented Mar 12, 2024

Previously, the relay neither scheduled a Wake command nor did it register a TimedAction to expire a channel binding. Such an action was only scheduled after the first refresh.

This PR fixes this and adds a test that asserts we can re-bind the same channel to a different peer after 15 minutes.

Resolves: #3979.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:02am

Copy link

github-actions bot commented Mar 12, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 7 to change, 9 to destroy.

Terraform Cloud Plan

Copy link
Collaborator

@conectado conectado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 63.4 MiB (+1%) 63.8 MiB (+1%) 30 (-32%)
direct-tcp-server2client 52.6 MiB (-1%) 52.9 MiB (-1%) 43 (+34%)
relayed-tcp-client2server 28.3 MiB (-4%) 31.0 MiB (-4%) 411 (+6%)
relayed-tcp-server2client 30.1 MiB (+7%) 32.3 MiB (+6%) 21 (-95%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.18ms (+8%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.19ms (-6%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.32ms (-32%) 21.65% (+7%)
relayed-udp-server2client 50.0 MiB (-0%) 1.32ms (+385%) 19.83% (-2%)

@thomaseizinger thomaseizinger added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 36848e3 Mar 12, 2024
137 checks passed
@thomaseizinger thomaseizinger deleted the fix/relay/actually-expire-channels branch March 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Peer is already bound to another channel"
2 participants