feat(linux): make deep link auth work #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
ReactorScram
commented
Mar 12, 2024
| @@ -1,18 +1,15 @@ | |||
| #!/bin/sh | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
all this stuff is unrelated to deep linking but happened to be changed on this branch.
Comment on lines
+94
to
+97
| ## Linux | ||
|
|
||
| - Dir `$HOME/.local/share/applications` (.desktop file for deep links. This dir may not even exist by default on distros like Debian) | ||
|
|
There was a problem hiding this comment.
Not complete yet but it's more than nothing.
Comment on lines
36
to
37
| // TODO: Delete this before opening PR | ||
| tracing::debug!(secret = url.expose_secret(), "Parsing URL"); |
| tracing::warn!("Not implemented yet"); | ||
| tracing::trace!(scheme = super::FZ_SCHEME, "prevents dead code warning"); | ||
| Ok(Self {}) | ||
| /// Create a new deep link server to make sure we're the only instance |
There was a problem hiding this comment.
Single-instance doesn't work on Linux yet. It's in #3884
jamilbk
reviewed
Mar 12, 2024
| @@ -212,6 +217,7 @@ pub enum Cmd { | |||
|
|
|||
| #[derive(Args)] | |||
| pub struct DeepLink { | |||
| // TODO: Should be `Secret`? | |||
There was a problem hiding this comment.
Yeah, but we can wait until the two-process arch is done before this
jamilbk
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it only works on my dev VM, not on my test VMs, due to #4053 and #4103, but it passes tests and should be safe to merge.
There's one doc fix and one script fix which are unrelated and could be their own PRs, but they'd be tiny, so I left them in here.
Ref #4106 and #3713 for the plan to fix all this by splitting the tunnel process off so that the GUI runs as a normal user.