-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux): make deep link auth work #4102
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output
|
Performance Test ResultsTCP
UDP
|
@@ -1,18 +1,15 @@ | |||
#!/bin/sh | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this stuff is unrelated to deep linking but happened to be changed on this branch.
## Linux | ||
|
||
- Dir `$HOME/.local/share/applications` (.desktop file for deep links. This dir may not even exist by default on distros like Debian) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not complete yet but it's more than nothing.
// TODO: Delete this before opening PR | ||
tracing::debug!(secret = url.expose_secret(), "Parsing URL"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
tracing::warn!("Not implemented yet"); | ||
tracing::trace!(scheme = super::FZ_SCHEME, "prevents dead code warning"); | ||
Ok(Self {}) | ||
/// Create a new deep link server to make sure we're the only instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single-instance doesn't work on Linux yet. It's in #3884
@@ -212,6 +217,7 @@ pub enum Cmd { | |||
|
|||
#[derive(Args)] | |||
pub struct DeepLink { | |||
// TODO: Should be `Secret`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but we can wait until the two-process arch is done before this
Right now it only works on my dev VM, not on my test VMs, due to #4053 and #4103, but it passes tests and should be safe to merge.
There's one doc fix and one script fix which are unrelated and could be their own PRs, but they'd be tiny, so I left them in here.
Ref #4106 and #3713 for the plan to fix all this by splitting the tunnel process off so that the GUI runs as a normal user.