Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apple): Handle network changes reliably on macOS and iOS #4133

Merged
merged 14 commits into from
Mar 27, 2024
Merged

feat(apple): Handle network changes reliably on macOS and iOS #4133

merged 14 commits into from
Mar 27, 2024

Commits on Mar 27, 2024

  1. Greatly simplify Apple client state

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e77d5ae View commit details
    Browse the repository at this point in the history

  2. Refactor how we store, parse, and display resources

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b78d67a View commit details
    Browse the repository at this point in the history

  3. Check for tunnel status moving back to .invalid on iOS

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1363672 View commit details
    Browse the repository at this point in the history

  4. Stricter settings field validators

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    34ba208 View commit details
    Browse the repository at this point in the history

  5. Fix spelling

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7953bcc View commit details
    Browse the repository at this point in the history

  6. Don't allow clicking Sign out when disconnecting

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d464659 View commit details
    Browse the repository at this point in the history

  7. Set DNS immediately after WrappedSession.connect

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    36c1bc8 View commit details
    Browse the repository at this point in the history

  8. Use kSecAttrAccessGroup for shared Keychain access on macOS too

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    828e062 View commit details
    Browse the repository at this point in the history

  9. Simplify signed out state

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2de10df View commit details
    Browse the repository at this point in the history

  10. rework AppLogger

    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    91b9a2f View commit details
    Browse the repository at this point in the history

  11. fix(apple): Don't crash on tunnel save if the configuration has been … 

    …removed (#4324)

- Handles an edge case where we would crash if the tunnel configuration
was removed in the middle of saving Settings.
- Handles an edge case where our tunnel configuration may have been
changed by the system -- if it was disabled, we disconnect.
    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5ff2898 View commit details
    Browse the repository at this point in the history

  12. fix(apple): Fix stuck menubar icon state (#4323) 

    When binding to published variables from other objects, we must use the
parameter received in the callback to act upon, and not re-read the
stored parameter on the associated object again.

The stored parameter can be stale, which leads to UI bugs where we
transitioned state but the menubar icon or menu did not get updated.

<img width="274" alt="Screenshot 2024-03-25 at 11 45 35 PM"
src="https://github.com/firezone/firezone/assets/167144/17a26b52-0599-4523-a7d1-d1bb2e617c44">


This fixes a long-standing bug that has occurred off and on since the
early versions.
    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    feb51f9 View commit details
    Browse the repository at this point in the history

  13. Update swift/apple/FirezoneKit/Sources/FirezoneKit/Views/MenuBar.swift 

    Co-authored-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
    @jamilbk @ReactorScram
    jamilbk and ReactorScram committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b81821a View commit details
    Browse the repository at this point in the history

  14. Update swift/apple/FirezoneNetworkExtension/NetworkSettings.swift 

    Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
    @jamilbk
    jamilbk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    13b3765 View commit details
    Browse the repository at this point in the history