Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): send Cidr format instead of IpNetwork format #4134

Merged
merged 6 commits into from
Mar 14, 2024
Merged

fix(android): send Cidr format instead of IpNetwork format #4134

merged 6 commits into from
Mar 14, 2024

Conversation

conectado
Copy link
Collaborator

@conectado conectado commented Mar 13, 2024 •
edited by thomaseizinger

Fixes android on main and remove the need to parse and re-parse addresses for android and swift.

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 6:46pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited

Terraform Cloud Plan Output

Plan: 8 to add, 7 to change, 8 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 196.7 MiB (-1%) 197.2 MiB (-1%) 235 (+3%)
direct-tcp-server2client 203.2 MiB (+1%) 204.6 MiB (+1%) 609 (-16%)
relayed-tcp-client2server 140.9 MiB (+2%) 141.4 MiB (+2%) 152 (0%)
relayed-tcp-server2client 141.9 MiB (-2%) 142.3 MiB (-2%) 186 (+22%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.05ms (+27%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.02ms (-30%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.09ms (-48%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.07ms (-6%) 0.00% (NaN%)

@conectado conectado force-pushed the fix/callback-update-routes-format branch 2 times, most recently from fecd941 to 9adf6cb Compare March 14, 2024 05:46
@conectado conectado marked this pull request as ready for review March 14, 2024 05:50
@conectado conectado force-pushed the fix/callback-update-routes-format branch from 1b939ea to a975ee5 Compare March 14, 2024 06:00
@thomaseizinger
Copy link
Member

Title needs updating.

ReactorScram
ReactorScram approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rust/connlib/tunnel/src/device_channel/tun_darwin.rs Show resolved Hide resolved
rust/connlib/shared/src/callbacks.rs Show resolved Hide resolved
@conectado @ReactorScram
Apply suggestions from code review
baa600d 
Co-authored-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Signed-off-by: Gabi <gabrielalejandro7@gmail.com>
jamilbk
jamilbk approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conectado conectado added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit 148bc8c Mar 14, 2024
134 checks passed
@conectado conectado deleted the fix/callback-update-routes-format branch March 14, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@ReactorScram ReactorScram ReactorScram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@conectado @thomaseizinger @jamilbk @ReactorScram