Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: propose process splitting for Linux #4153

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

ReactorScram
Copy link
Collaborator

No description provided.

@ReactorScram ReactorScram added area/linux_client Linux client kind/chore Issues related to repository cleanup or maintenance area/tauri_client The Windows and Linux Tauri GUI clients labels Mar 14, 2024
@ReactorScram ReactorScram self-assigned this Mar 14, 2024
Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 4:16pm

Copy link

github-actions bot commented Mar 14, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 8 to change, 9 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Mar 14, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 237.0 MiB (+4%) 238.9 MiB (+4%) 347 (+58%)
direct-tcp-server2client 230.5 MiB (-3%) 231.8 MiB (-3%) 326 (+48%)
relayed-tcp-client2server 151.6 MiB (+6%) 152.4 MiB (+6%) 191 (+15%)
relayed-tcp-server2client 151.6 MiB (-0%) 152.1 MiB (-0%) 200 (+33%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.05ms (+25%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-2%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.08ms (-53%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.05ms (-14%) 0.00% (NaN%)

@ReactorScram ReactorScram marked this pull request as ready for review March 15, 2024 16:13
rust/gui-client/docs/process_split.md Outdated Show resolved Hide resolved
rust/gui-client/docs/process_split.md Outdated Show resolved Hide resolved
rust/gui-client/docs/process_split.md Outdated Show resolved Hide resolved
I gave them new names to clarify.

1. `firezoned` - A daemon that runs the tunnel and has elevated privilege
2. `firezonectl` - A CLI program that runs unprivileged and exits once each operation is complete, like `systemctl` or `nmcli`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting but we maybe we can defer to later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so there's only 2 binaries, the privileged tunnel for the GUI is same binary as the CLI client?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I was thinking to keep things simpler? But if there's a good reason to split them up I don't feel strongly

rust/gui-client/docs/process_split.md Show resolved Hide resolved
rust/gui-client/docs/process_split.md Show resolved Hide resolved
rust/gui-client/docs/process_split.md Show resolved Hide resolved
@ReactorScram ReactorScram added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 8bad6a3 Mar 18, 2024
137 checks passed
@ReactorScram ReactorScram deleted the chore/doc-process-split branch March 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants