wip: re-architect how we initialize the TUN device #4159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
thomaseizinger
force-pushed
the
refactor/connlib/no-error-on-tunnel-ready
branch
3 times, most recently
from
a98c40d
to
44200aa
Compare
Base automatically changed from
refactor/connlib/no-error-on-tunnel-ready
to
main
March 20, 2024 02:20
thomaseizinger
force-pushed
the
refactor/connlib/no-return-fd
branch
from
a18f67d
to
02e2b2f
Compare
This was referenced Apr 1, 2024
|
Closing this in favor of several smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the callbacks for initializing and updating the TUN device create a lot of back-and-forth control flow that is hard to follow. This PR presents the cornerstones of a different design that I deem simpler to understand.
The key differences are:
Tunnelhas anupdate_tunfunction that allows setting a new TUN device. EssentiallyTunis now just anAsyncRead + AsyncWriteso that could be further abstracted. I think that would be good because we end up with less conditional dependencies.on_set_interface_configmeans the portal has given us new IPs. We set those IPs on the TUN device in a platform-specific way. For example, for Linux, this means talking tonetlink, for Android and iOS/MacOS, this means forwarding to the main app.Session. For Android, we have to wait for the file-descriptor from the first callback.