fix(connlib): exclude sentinel dns range for resources ips

[conectado]

In the future we will want to refactor this to a builder pattern to prevent the number of parameters from growing and have them clearer but this works simply for now.

Found while discussing #4174

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
firezone	⬜️ Ignored (Inspect)	Visit Preview		Mar 18, 2024 11:52pm

[github-actions]

Terraform Cloud Plan Output

Plan: 9 to add, 8 to change, 9 to destroy.

Terraform Cloud Plan

[jamilbk]

LGTM, deferring to @thomaseizinger

[github-actions]

Performance Test Results

TCP

Test Name	Received/s	Sent/s	Retransmits
direct-tcp-client2server	229.1 MiB (+0%)	230.1 MiB (+0%)	151 (-10%)
direct-tcp-server2client	235.1 MiB (-0%)	236.3 MiB (-1%)	364 (+1%)
relayed-tcp-client2server	149.2 MiB (+1%)	150.0 MiB (+1%)	187 (+42%)
relayed-tcp-server2client	163.2 MiB (+1%)	163.5 MiB (+1%)	158 (-9%)

UDP

Test Name	Total/s	Jitter	Lost
direct-udp-client2server	50.0 MiB (+0%)	0.04ms (-39%)	0.00% (NaN%)
direct-udp-server2client	50.0 MiB (+0%)	0.01ms (+14%)	0.00% (NaN%)
relayed-udp-client2server	50.0 MiB (-0%)	0.11ms (+1%)	0.00% (NaN%)
relayed-udp-server2client	50.0 MiB (+0%)	0.05ms (+11%)	0.00% (NaN%)

[thomaseizinger]

If you are always passing constants, why don't you just make two constructors that use those constants internally?

Seems to be easier to understand to me.

Also, can IpProvider just move into firezone_tunnel? Why does it sit in shared?

[conectado]

To be honest I still prefer passing the ranges in the constructor, seems more explicit to me.

[thomaseizinger]

To be honest I still prefer passing the ranges in the constructor, seems more explicit to me.

It is just a level of indirection though. Unless we use it with dynamic ranges, it seems to make more sense to just make two constructors:

impl IpProvider {
	fn client() -> Self { }
	fn gateway() -> Self { }
}

[thomaseizinger]

To be honest I still prefer passing the ranges in the constructor, seems more explicit to me.

It is just a level of indirection though. Unless we use it with dynamic ranges, it seems to make more sense to just make two constructors:

You can always dispatch to a more generic constructor from there.

[thomaseizinger]

To be honest I still prefer passing the ranges in the constructor, seems more explicit to me.

It is just a level of indirection though. Unless we use it with dynamic ranges, it seems to make more sense to just make two constructors:

impl IpProvider {
	fn client() -> Self { }
	fn gateway() -> Self { }
}

Oh I misunderstand how this is used. Nvm the client / gateway terminology.