fix(connlib): remove outdated assertion due to possibility of network changes #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
… changes and drain events after refreshing allocations on reconnect
conectado
force-pushed
the
fix/remove-outdated-assertion
branch
from
cd4446c
to
45fd085
Compare
thomaseizinger
requested changes
Mar 19, 2024
rust/connlib/snownet/src/node.rs
Outdated
| @@ -144,6 +144,8 @@ where | |||
| for allocation in self.allocations.values_mut() { | |||
| allocation.refresh(now); | |||
| } | |||
|
|
|||
| self.bindings_and_allocations_drain_events(); | |||
There was a problem hiding this comment.
This is actually wrong. refresh is async so we don't have any events here. But we should add this function to the top of poll_event to ensure we drain them in time.
There was a problem hiding this comment.
Should I do it with this PR?
There was a problem hiding this comment.
If you want to. I just don't want to add this here because it is pointless :)
Performance Test ResultsTCP
UDP
|
|
@conectado That seems to break the snownet tests as those are very strict on what gets emitted when. I reckon just remove it for now. We might remove those tests soon and I don't want to block this on it. Also, your PR title needs to be updated to match the implementation of the PR. |
conectado
force-pushed
the
fix/remove-outdated-assertion
branch
2 times, most recently
from
19a6a88
to
3537718
Compare
conectado
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found while working on #4163