Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): Fix various issues with presence-triggered table reloads #4228

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

AndrewDryga
Copy link
Collaborator

Also, cover that code with tests.

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 5:26pm

Copy link

github-actions bot commented Mar 20, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 8 to change, 9 to destroy.

Terraform Cloud Plan

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 224.7 MiB (+2%) 226.4 MiB (+3%) 156 (-20%)
direct-tcp-server2client 226.8 MiB (+3%) 228.5 MiB (+3%) 414 (+121%)
relayed-tcp-client2server 145.9 MiB (+2%) 146.7 MiB (+2%) 158 (+22%)
relayed-tcp-server2client 149.8 MiB (-0%) 150.2 MiB (-0%) 198 (-2%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.24ms (+786%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-19%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.21ms (+141%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.04ms (-25%) 0.00% (NaN%)

Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewDryga AndrewDryga merged commit 392adc9 into main Mar 20, 2024
138 checks passed
@AndrewDryga AndrewDryga deleted the andrew/presence-updates-tests branch March 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants