Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): Add styled errors pages (404, 422, 500) #4231

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

bmanifold
Copy link
Collaborator

Closes #2136

Screenshots for 404 and 500

Screenshot 2024-03-20 at 1 16 46 PM Screenshot 2024-03-20 at 1 16 30 PM

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 2:51pm

Copy link

github-actions bot commented Mar 20, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 8 to change, 8 to destroy.

Terraform Cloud Plan

@bmanifold
Copy link
Collaborator Author

As a quick note, I pretty much just followed this doc page: https://hexdocs.pm/phoenix/custom_error_pages.html

@AndrewDryga If there is a better way of doing this just let me know and I'll update the PR.

@AndrewDryga
Copy link
Collaborator

LGTM. I always dreamed about nice funny error pages like those https://codepen.io/affectionatelettuce/pen/BarrJKJ but we need a designer for that :).

@jamilbk
Copy link
Member

jamilbk commented Mar 20, 2024

but we need a designer for that :).

I'm sure there's an AI tool that can make us one!

@bmanifold
Copy link
Collaborator Author

Yeah, I'm down to make something funnier, I just did these because it was easy. I'm no animator though, I'd definitely need to find a pre-made animation if we wanted to do something like you linked.

@jamilbk
Copy link
Member

jamilbk commented Mar 20, 2024

Cool it! You're making too many requests

stable-diffusion-turbo

@AndrewDryga
Copy link
Collaborator

ChatGPT did an image for us:
DALL·E 2024-03-20 18 31 04 - A humorous scene for a HTTP 500 error page, suitable for a light grey background, featuring a network technician named Andrew  Andrew, depicted in a c

Copy link

github-actions bot commented Mar 21, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 228.2 MiB (+2%) 229.9 MiB (+2%) 241 (-46%)
direct-tcp-server2client 230.2 MiB (-0%) 231.7 MiB (-0%) 65 (-89%)
relayed-tcp-client2server 151.4 MiB (+5%) 152.1 MiB (+4%) 139 (-10%)
relayed-tcp-server2client 147.6 MiB (-5%) 148.1 MiB (-5%) 182 (-21%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.30ms (+687%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-6%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.09ms (+3%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.08ms (+70%) 0.00% (NaN%)

@bmanifold bmanifold changed the title feature(portal): Add styled errors pages (404, 422, 500) feat(portal): Add styled errors pages (404, 422, 500) Mar 21, 2024
@bmanifold bmanifold added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit f5286d0 Mar 22, 2024
138 checks passed
@bmanifold bmanifold deleted the feature/error-page-styling branch March 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style 404 and 500 error pages
3 participants