refactor(connlib): explicitly set DNS from clients instead of requesting it via callback #4240
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
conectado
force-pushed
the
refactor/use-set-dns-instead-of-callback
branch
2 times, most recently
from
b99e4eb
to
d0ade0c
Compare
Terraform Cloud Plan Output |
| firezone_tunnel::ClientEvent::RefreshInterfance => { | ||
| unreachable!("Handled internally"); | ||
| } |
There was a problem hiding this comment.
I'd like to not re-introduce something like this now that we have removed the old instances of it. We should make an internal event or something for the state to communicate with the Io runtime.
rust/connlib/tunnel/src/client.rs
Outdated
| #[test] | ||
| fn dns_updated_when_dns_changes() { | ||
| assert!(dns_updated( | ||
| &["1.0.0.1".parse().unwrap()], |
There was a problem hiding this comment.
I'd appreciate a helper function like ip that hides the noise of .parse().unwrap() for these tests.
| } | ||
|
|
||
| self.next_system_resolver_refresh = Some(now + std::time::Duration::from_millis(500)); | ||
| self.system_resolvers = new_dns; |
There was a problem hiding this comment.
Is it a good idea to already overwrite this? Wouldn't it be better to store this together with the timeout and only apply it once the timeout expires?
There was a problem hiding this comment.
I don't think there's any harm on setting it here, it's easier to implement and if for some reason update_interface is called earlier there's no harm on setting the latest dns
Performance Test ResultsTCP
UDP
|
thomaseizinger
changed the title
| Some(client::Event::SignalIceCandidate { conn_id, candidate }) => { | ||
| return Poll::Ready(Ok(ClientEvent::SignalIceCandidate { conn_id, candidate })) | ||
| } | ||
| Some(client::Event::ConnectionIntent { | ||
| resource, | ||
| connected_gateway_ids, | ||
| }) => { | ||
| return Poll::Ready(Ok(ClientEvent::ConnectionIntent { | ||
| resource, | ||
| connected_gateway_ids, | ||
| })) | ||
| } | ||
| Some(client::Event::RefreshResources { connections }) => { | ||
| return Poll::Ready(Ok(ClientEvent::RefreshResources { connections })) | ||
| } |
There was a problem hiding this comment.
You could solve this with a little less boilerplate by implementing From:
Some(other) => {
return Poll::Ready(Ok(ClientEvent::from(other)))
}There was a problem hiding this comment.
Hmm, that has a fallible codepath then. Nevermind.
conectado
force-pushed
the
refactor/use-set-dns-instead-of-callback
branch
from
309375e
to
56d7ded
Compare
Extracted from #4163
Dependant PRs:
#4198
#4133
#4163