feat(linux-client): load token from /etc/dev.firezone.client ...
#4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not in CLI / env var This is more convenient for development, and it's a step towards getting the systemd service to work.
ReactorScram
added
kind/feature
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ReactorScram
commented
Mar 26, 2024
| @@ -21,3 +21,4 @@ humantime = "2.1" | |||
| resolv-conf = "0.7.0" | |||
| thiserror = "1.0.57" | |||
| tokio = { version = "1.36", default-features = false, features = ["rt", "macros", "signal"] } | |||
| url = { version = "2.3.1", default-features = false } | |||
There was a problem hiding this comment.
I'm not sure how it's deserializing URLs if I turned off all the features. I wonder if it's one of those glitches where this package doesn't ask for a feature, but another package in the workspace does, so we get a feature we didn't ask for and silently succeed when technically the Cargo.toml manifest is not correct.
There was a problem hiding this comment.
I'm not sure if that's consider a glitch, but I think it's that
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's not in CLI / env var
This is more convenient for development, and it's a step towards getting the systemd service to work.
The token:
/usr/lib/systemd/system/firezone-client.servicebecause that file is updated bydpkgIt has to be stored on disk somewhere for headless operation, so we can just read it directly from disk.