Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): Fix pagination issues with flows and activities, improve error handling around live tables #4330

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

AndrewDryga
Copy link
Collaborator

Fixes issues from logs.
Closes #4274 and similar issues for activities.
Simplifies error handling for live tables (we just reset filters with a message when they are invalid because just showing an error 422 is not actionable).

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 6:49pm

Copy link

github-actions bot commented Mar 26, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Mar 26, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 224.8 MiB (+1%) 227.4 MiB (+1%) 164 (+7%)
direct-tcp-server2client 224.0 MiB (+1%) 225.8 MiB (+1%) 295 (-31%)
relayed-tcp-client2server 146.6 MiB (+4%) 147.4 MiB (+4%) 158 (-11%)
relayed-tcp-server2client 152.6 MiB (+1%) 152.9 MiB (+1%) 195 (+36%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.31ms (-1%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.01ms (-66%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.07ms (-15%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.05ms (+6%) 0.00% (NaN%)

@AndrewDryga AndrewDryga changed the title More bugfixes fix(portal): Fix pagination issues with flows and activities, improve error handling around live tables Mar 27, 2024
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewDryga AndrewDryga merged commit 21d2ca3 into main Mar 27, 2024
152 checks passed
@AndrewDryga AndrewDryga deleted the andrew/bugixes branch March 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can only view 3 pages of 15
2 participants