Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple client): sign in crash, closes #4350 #4353

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(apple client): sign in crash, closes #4350 #4353

merged 1 commit into from
Mar 27, 2024

Conversation

ReactorScram
Copy link
Collaborator

No description provided.

@ReactorScram ReactorScram added the area/apple_client Issues related to the Apple client label Mar 27, 2024
@ReactorScram ReactorScram added this to the 1.0 GA milestone Mar 27, 2024
@ReactorScram ReactorScram self-assigned this Mar 27, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Mar 27, 2024 9:01pm

@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

@ReactorScram ReactorScram marked this pull request as ready for review March 27, 2024 21:06
@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 225.0 MiB (+1%) 226.5 MiB (+1%) 184 (+14%)
direct-tcp-server2client 219.9 MiB (-4%) 221.6 MiB (-4%) 354 (+32%)
relayed-tcp-client2server 144.3 MiB (-1%) 145.0 MiB (-1%) 178 (+24%)
relayed-tcp-server2client 156.9 MiB (+1%) 157.2 MiB (+1%) 215 (+45%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (0%) 0.04ms (+27%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.01ms (-1%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.17ms (+22%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.07ms (+16%) 0.00% (NaN%)

@ReactorScram ReactorScram added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@ReactorScram ReactorScram added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@ReactorScram ReactorScram added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit 26c78cd Mar 27, 2024
152 checks passed
@ReactorScram ReactorScram deleted the fix/apple-sign-in-crash branch March 27, 2024 21:40
@conectado conectado mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

@conectado conectado Awaiting requested review from conectado

Assignees

@ReactorScram ReactorScram

Labels
area/apple_client Issues related to the Apple client
Projects
None yet
Milestone
1.0 GA
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReactorScram @jamilbk