Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): Do not redact userpass virtual state (its a virtual field anyway) #4370

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

AndrewDryga
Copy link
Collaborator

Closes #4354

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Mar 28, 2024 5:02pm

Copy link

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 219.3 MiB (-4%) 220.9 MiB (-4%) 163 (-9%)
direct-tcp-server2client 222.5 MiB (-1%) 223.3 MiB (-1%) 333 (+12%)
relayed-tcp-client2server 147.6 MiB (+0%) 148.4 MiB (+0%) 149 (-14%)
relayed-tcp-server2client 151.3 MiB (-2%) 151.7 MiB (-2%) 122 (-39%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.04ms (-87%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-34%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.12ms (+50%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.05ms (+12%) 0.00% (NaN%)

@AndrewDryga AndrewDryga changed the title Do not redact userpass virtual state (its a virtual field anyway) fix(portal): Do not redact userpass virtual state (its a virtual field anyway) Mar 28, 2024
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewDryga AndrewDryga merged commit 582a5ef into main Mar 28, 2024
152 checks passed
@AndrewDryga AndrewDryga deleted the andrew/userpass-fix branch March 28, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(portal): Form for new user using UserPass provider not working
2 participants