Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(relay): remove heap-allocations from hotpath #4457

Merged
merged 15 commits into from
Apr 4, 2024
Merged

refactor(relay): remove heap-allocations from hotpath #4457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f82a0ea
Remove `AllocationId` in favor of just using the port for indexing
thomaseizinger Apr 2, 2024
6f23dc9
Introduce dedicated worker thread that listens for `mio` events
thomaseizinger Apr 2, 2024
72672d9
Don't allocate for peer messages
thomaseizinger Apr 2, 2024
2ba7949
Don't allocate for client messages
thomaseizinger Apr 2, 2024
41232f3
Add redundant hashmap to avoid look-ups during routing
thomaseizinger Apr 2, 2024
c72e9f0
Use `ChannelNumber` newtype instead of u16
thomaseizinger Apr 3, 2024
1e1fc42
Make channel bounded
thomaseizinger Apr 3, 2024
27cd1b1
Merge branch 'main' into refactor/relay/mio
thomaseizinger Apr 4, 2024
a2ea716
Add more comments
thomaseizinger Apr 4, 2024
0560eb5
Introduce constant for TURN port
thomaseizinger Apr 4, 2024
df076e7
Increase capacity of command channel to worker-thread
thomaseizinger Apr 4, 2024
b5bff3e
Add more docs
thomaseizinger Apr 4, 2024
606a9ce
Drain all events instead of waiting for up to 1 second inbetween each
thomaseizinger Apr 4, 2024
09b39d7
Add more docs
thomaseizinger Apr 4, 2024
a8c75c1
Remove now useless spans and add better info logs
thomaseizinger Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rust/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions rust/relay/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ trackable = "1.3.0"
socket2 = "0.5.6"
backoff = "0.4"
http-health-check = { workspace = true }
mio = "0.8.11"

[dev-dependencies]
difference = "2.0.0"
Expand Down
111 changes: 0 additions & 111 deletions rust/relay/src/allocation.rs
View file
Open in desktop

This file was deleted.

9 changes: 3 additions & 6 deletions rust/relay/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,19 @@
mod allocation;
mod auth;
mod net_ext;
mod server;
mod sleep;
mod udp_socket;

#[cfg(feature = "proptest")]
pub mod proptest;
pub mod sockets;

pub use allocation::Allocation;
pub use net_ext::IpAddrExt;
pub use server::{
Allocate, AllocationId, Attribute, Binding, ChannelBind, ChannelData, ClientMessage, Command,
CreatePermission, PeerToClient, Refresh, Server,
Allocate, AllocationPort, Attribute, Binding, ChannelBind, ChannelData, ClientMessage, Command,
CreatePermission, Refresh, Server,
};
pub use sleep::Sleep;
pub use stun_codec::rfc8656::attributes::AddressFamily;
pub use udp_socket::UdpSocket;

use std::{
fmt,
Expand Down
Loading
Loading