Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): Fix bug with preset values in policies dropdowns #4693

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

AndrewDryga
Copy link
Collaborator

Closes #4688

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 10:30pm

@AndrewDryga AndrewDryga changed the title Fix bug with preset values in policies dropdowns fix(portal): Fix bug with preset values in policies dropdowns Apr 18, 2024
@github-actions github-actions bot added the kind/bug Something isn't working label Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 2 to destroy.

Terraform Cloud Plan

@@ -137,6 +137,12 @@ defmodule Web.FormComponents do
~H"""
<div phx-feedback-for={@name}>
<.label for={@id}><%= @label %></.label>
<input
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<select> does not send the data if it's disabled, so we add a hidden input that will do the job for it.

Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 246.3 MiB (+3%) 249.0 MiB (+4%) 412 (+23%)
direct-tcp-server2client 242.3 MiB (+0%) 243.9 MiB (+0%) 390 (+31%)
relayed-tcp-client2server 223.5 MiB (-0%) 224.5 MiB (-0%) 331 (+15%)
relayed-tcp-server2client 240.3 MiB (+1%) 241.0 MiB (+1%) 295 (-15%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.05ms (+28%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.01ms (+20%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.03ms (-76%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (-0%) 0.01ms (-65%) 0.00% (NaN%)

@AndrewDryga AndrewDryga merged commit 89dd4c5 into main Apr 18, 2024
125 checks passed
@AndrewDryga AndrewDryga deleted the andrew/policies-preset-values-bug branch April 18, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create Policy when group is pre-filled
3 participants